You will find the weather in Luxor to be a bit extreme. The summers can be unbearable and also intensely hot. If you do not enjoy getting too hot, you will find your stay very uncomfortable and unpleasant. The winters can also get very cold so much that it can be difficult to travel there.
The best time to travel to Luxor would be when the weather is a little more bearable and you won’t feel too uncomfortable when out and about. Make sure that if you are planning a vacation in Luxor that you visit between October and March. It is normally much cooler during this period. Otherwise all the other months may not be a good time.